[ https://issues.apache.org/jira/browse/TINKERPOP-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15535982#comment-15535982 ]
ASF GitHub Bot commented on TINKERPOP-1470: ------------------------------------------- Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/445 Ran integration tests overnight. ``` [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 05:12 h [INFO] Finished at: 2016-09-29T21:09:28-06:00 [INFO] Final Memory: 121M/1519M [INFO] ------------------------------------------------------------------------ ``` > InlineFilterStrategy should try and P.or() has() children in OrSteps. > --------------------------------------------------------------------- > > Key: TINKERPOP-1470 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1470 > Project: TinkerPop > Issue Type: Improvement > Components: process > Affects Versions: 3.2.2 > Reporter: Marko A. Rodriguez > Assignee: Marko A. Rodriguez > > The following patterns: > {code} > g.V().or(has("age",gt(20)), has("age",lt(32))) > g.V().and(or(has("age",gt(20)), has("age",lt(32))),has("age",neq(23)) > {code} > should be re-written by {{InlineFilterStrategy}} as: > {code} > g.V().has("age",gt(20).or(lt(32))) > g.V().has("age",gt(20).or(lt(32)).and(neq(23))) > {code} > This would then make it easier for provider strategies to fold the predicate > into graph/vertex-centric push down predicates accordingly. > Note that {{InlineFilterStep}} already has the code to flatten {{AndSteps}}. > Thus, during its recursion, it would do the following rewrites to get to the > final form. > {code} > g.V().and(or(has("age",gt(20)), has("age",lt(32))),has("age",neq(23)) > g.V().or(has("age",gt(20)), has("age",lt(32))).has("age",neq(23)) > g.V().has("age",gt(20).or(lt(32))).has("age",neq(23)) > g.V().has("age",gt(20).or(lt(32)).and(neq(23))) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)