[ https://issues.apache.org/jira/browse/TINKERPOP-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15536213#comment-15536213 ]
ASF GitHub Bot commented on TINKERPOP-1483: ------------------------------------------- Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/446 Hm. This is a hard pill to swallow as its not backwards compatible. I was thinking you were going to go the route of making it `Map<Object,Object>` and thus, allow the enums as they are. If people have code that is `map.get(id)`, your changes will break their code. > PropertyMapStep returns Map<String,E> but puts non String keys in it! > --------------------------------------------------------------------- > > Key: TINKERPOP-1483 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1483 > Project: TinkerPop > Issue Type: Bug > Components: process > Affects Versions: 3.2.2 > Reporter: JP Moresmau > > PropertyMapStep.map has return type Map<String,E>, but if includeTokens is > true: > {code} > if (element instanceof VertexProperty) { > map.put(T.id, element.id()); > map.put(T.key, ((VertexProperty) element).key()); > map.put(T.value, ((VertexProperty) element).value()); > } else { > map.put(T.id, element.id()); > map.put(T.label, element.label()); > } > {code} > T.id, T.key and T.value are NOT strings, so code looping through the keys in > Java fails. toString() are missing... But do we rely on having these keys in > other operations? -- This message was sent by Atlassian JIRA (v6.3.4#6332)