[
https://issues.apache.org/jira/browse/TINKERPOP-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15564338#comment-15564338
]
Jason Plurad commented on TINKERPOP-1493:
-----------------------------------------
[~pauljackson] Thanks for looking into this. Nice work.
If you're working off master, there were recent changes that moved it into
integration test (TINKERPOP-1477). You can execute these by running
{noformat}
mvn clean verify -DskipIntegrationTests=false
{noformat}
I tried out your fixes, and they mostly look good. I found that it needed to
call {{jar.close()}} in {{DependencyGrabber.alterPaths()}} also.
Will you be able to submit a pull request?
> Groovy project doesn't build on Windows
> ---------------------------------------
>
> Key: TINKERPOP-1493
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1493
> Project: TinkerPop
> Issue Type: Bug
> Components: groovy
> Affects Versions: 3.2.2
> Reporter: Paul Jackson
> Priority: Minor
>
> Builds on Windows fail for two reasons. First the line to create extTestDir
> is creating a path consisting of two full paths concatenated together. The
> second drive letter is seen as an illegal character:
> {code}private static final File extTestDir = new
> File(System.getProperty("user.dir"),
> TestHelper.makeTestDataDirectory(DependencyGrabberTest.class));{code}
> Second, when it comes time to delete the directory it is locked. This is
> because some instances of JarFile are created on it but not closed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
