GitHub user okram opened a pull request:

    https://github.com/apache/tinkerpop/pull/455

    TINKERPOP-1495: Global list deduplication doesn't work in OLAP

    https://issues.apache.org/jira/browse/TINKERPOP-1495
    
    Two bugs fixed. One is simple -- `RepeatStep` wasn't adding labels to the 
"emit traverser" in OLAP. One line update to `RepeatStep.RepeatEndStep`. The 
other is related to some `GraphComputing` steps should behave differently if 
they are being executed at master or workers. In particular, `DedupGlobalStep`. 
    
    Added two new test cases to `DedupTest` provided from the list that 
demonstrates the two problems (and shows they are now solved).
    
    VOTE +1.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1495

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/455.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #455
    
----
commit 0dcf65921b6045d734d1d6230309f2a1de4f4ee5
Author: Marko A. Rodriguez <[email protected]>
Date:   2016-10-11T14:20:31Z

    added GraphComputing.atMaster(boolean) to allow steps (if the want) to know 
whether they are executing locally at master or distributed across workers. 
This fixes a bug in dedup() on OLAP where non-element traversers were not being 
dedup'd correctly.

commit 85eebfab89d9c130f9515e1e8953589a22f8e449
Author: Marko A. Rodriguez <[email protected]>
Date:   2016-10-11T15:06:28Z

    Fixed a bug in OLAP RepeatStep where emit().as('x') wasn't behaving 
correctly. Basically, forgot to add the step labels to the emitTraverser. One 
line fix. Added the complex @dkuppitz traversal DedupTest which demonstrates 
that local dedup works correctly in OLAP.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to