validate-distribution.sh - OK gremlin-python tests pass on Python 2
Unfortunately, the new GraphSONWriter PR introduced a subtle bug that manifests when testing against Python 3. This is due to the fact that `long` does not differ from `int` in Python 3. The introduced `long` class, which should cause the value to be serialized as "g:int64", is sometimes interpreted as an `int` by the type checker, and therefore produces "g:int32". This wasn't a problem before, because the order of type checking was controlled. Now all of the serializers are stored in an unordered map, and therefore a `long` can be interpreted as an `int` or a `long`, whichever type check happens first. Therefore, the tests don't always fail, and this bug was missed during review. I don't think that the original solution to this problem was the best either (just doing the type checks in order), so maybe we should discuss a better way to implement this for the next release. Anyway, I don't think this is a show stopper, just something that should be fixed/improved in the next release. VOTE + 1 On Thu, Oct 20, 2016 at 9:58 AM, Daniel Kuppitz <m...@gremlin.guru> wrote: > docker/build.sh -t -i -n -j -d (1x everything) succeeded. > > VOTE: +1 > > On Mon, Oct 17, 2016 at 11:21 PM, Stephen Mallette <spmalle...@gmail.com> > wrote: > >> Hello, >> >> We are happy to announce that TinkerPop 3.2.3 is ready for release. >> >> The release artifacts can be found at this location: >> https://dist.apache.org/repos/dist/dev/tinkerpop/3.2.3/ >> >> The source distribution is provided by: >> apache-tinkerpop-3.2.3-src.zip >> >> Two binary distributions are provided for user convenience: >> apache-tinkerpop-gremlin-console-3.2.3-bin.zip >> apache-tinkerpop-gremlin-server-3.2.3-bin.zip >> >> The GPG key used to sign the release artifacts is available at: >> https://dist.apache.org/repos/dist/dev/tinkerpop/KEYS >> >> The online docs can be found here: >> http://tinkerpop.apache.org/docs/3.2.3/ (user docs) >> http://tinkerpop.apache.org/docs/3.2.3/upgrade/ (upgrade docs) >> http://tinkerpop.apache.org/javadocs/3.2.3/core/ (core javadoc) >> http://tinkerpop.apache.org/javadocs/3.2.3/full/ (full javadoc) >> >> The tag in Apache Git can be found here: >> >> https://git-wip-us.apache.org/repos/asf?p=tinkerpop.git;a=tag;h= >> 0fdd98d8b657185b766310562926c155427594d6 >> >> The release notes are available here: >> >> https://github.com/apache/tinkerpop/blob/master/ >> CHANGELOG.asciidoc#tinkerpop-323-release-date-october-17-2016 >> >> The [VOTE] will be open for the next 72 hours --- closing Thursday (October >> 20, 2016) at 5:30pm EST. >> >> My vote is +1. >> >> Thank you very much, >> Stephen >> -- David M. Brown R.A. CulturePlex Lab, Western University
