[ https://issues.apache.org/jira/browse/TINKERPOP-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15605209#comment-15605209 ]
ASF GitHub Bot commented on TINKERPOP-1507: ------------------------------------------- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/460 Note that the graphson.asciidoc generation isn't automatic. it's a script you have to run manually (so the content it generates isn't currently present if you were to generate docs). It can be run later i guess. Like i said, it's not a terribly automated process atm. All tests pass with `docker/build.sh -t -n -i` VOTE +1 > Pick.any and Pick.none are not in GraphSON or Gremlin-Python > ------------------------------------------------------------ > > Key: TINKERPOP-1507 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1507 > Project: TinkerPop > Issue Type: Improvement > Components: io, language-variant, process > Affects Versions: 3.1.4, 3.2.2 > Reporter: Marko A. Rodriguez > Assignee: Marko A. Rodriguez > > There are numerous "tokens" (enums) in Gremlin -- {{T}}, {{Order}}, > {{Compare}}, etc. > We forgot {{Pick}}. Doh. {{Pick}} is used in branch-options to support > "default" and "all"-type semantics in switch behavior. We need to add it to > GraphSON and Gremlin-Python. > More generally, I think we should consolidate all the "tokens" into a single > Java file. > {code} > public class Tokens { > public enum T { .. } > public enum Order { .. } > public enum VertexCardinality { ..} > public enum Compare { .. } > public enum Pick { .. } > ... > } > {code} > We could make it backwards compatible by: > {code} > T.label = Tokens.T.label. > {code} > By having all this consolidate, we will more easily know what we have and > will be better able to use reflection in language variant generators. -- This message was sent by Atlassian JIRA (v6.3.4#6332)