[
https://issues.apache.org/jira/browse/TINKERPOP-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15636205#comment-15636205
]
ASF GitHub Bot commented on TINKERPOP-1211:
-------------------------------------------
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/475#discussion_r86534725
--- Diff: CHANGELOG.asciidoc ---
@@ -26,6 +26,7 @@
image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima
TinkerPop 3.3.0 (Release Date: NOT OFFICIALLY RELEASED YET)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+* `UnfoldStep` now supports unfolding of arrays. (*breaking*)
--- End diff --
I don't really like the use of "breaking" in the CHANGELOG for our manual
entries. The JIRA ticket will have that when we generate that list on release.
Also, we've not done that consistently from the start of CHANGELOG. If
something is "breaking" the better way to call attention to it is in the
upgrade docs where we can better describe and demonstrate the change for users
rather than a single one-liner in CHANGELOG.
> UnfoldStep should unfold arrays.
> --------------------------------
>
> Key: TINKERPOP-1211
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1211
> Project: TinkerPop
> Issue Type: Bug
> Components: process
> Affects Versions: 3.1.1-incubating
> Reporter: Marko A. Rodriguez
> Assignee: Marko A. Rodriguez
> Labels: breaking
> Fix For: 3.3.0
>
>
> Currently {{UnfoldStep}} does not unfold arrays as an array does not
> implement {{Iterable}} or {{Iterator}}. We simply need to check if the
> current object is an array, and if so, set the flatMap-iterator to
> {{ArrayIterator}}.
> This would be breaking, but I doubt anyone ever uses arrays or would find
> this a problem. I'm sure anyone who wanted to {{unfold}} an array was like:
> "whaaaaa?"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
