[ 
https://issues.apache.org/jira/browse/TINKERPOP-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15761810#comment-15761810
 ] 

ASF GitHub Bot commented on TINKERPOP-1581:
-------------------------------------------

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/515
  
    After the recent additional fix from @davebshow this seems to now pass 
consistently. I've done a number of test runs with docker and my local 
environments and all is good.
    
    VOTE +1


> Gremlin-Python driver connection is not thread safe.
> ----------------------------------------------------
>
>                 Key: TINKERPOP-1581
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1581
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: language-variant
>    Affects Versions: 3.2.3
>            Reporter: Marko A. Rodriguez
>             Fix For: 3.2.4
>
>
> From Dave on the mailing list.
> gremlin-python should work fine with threads, but there is a bug in the 
> current code that makes it ignore the 'loop' parameter when it's there (and 
> puts all calls on the same loop when it isn't, leading to crashes when 
> running many threads):
> At line 43 in driver_remote_connection.py (function `DriverRemoteConnection`):
> {code}
>         if loop is None:
>             self._loop = ioloop.IOLoop.current()
> {code}
> should be:
> {code}
>         if loop is None:
>             self._loop = ioloop.IOLoop.current()
>         else:
>             self._loop = loop
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to