[
https://issues.apache.org/jira/browse/TINKERPOP-1545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15811974#comment-15811974
]
ASF GitHub Bot commented on TINKERPOP-1545:
-------------------------------------------
GitHub user dkuppitz opened a pull request:
https://github.com/apache/tinkerpop/pull/525
TINKERPOP-1545 IncidentToAdjacentStrategy is buggy
https://issues.apache.org/jira/browse/TINKERPOP-1545
Implemented changes as discussed in
https://github.com/apache/tinkerpop/pull/486.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1545-tp31
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/525.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #525
----
commit 52e3b86c06938c3427b2452c39a44b75d92e5a6f
Author: Daniel Kuppitz <daniel_kupp...@hotmail.com>
Date: 2017-01-09T14:31:54Z
Fixed bug in `IncidentToAdjacentStrategy`, it was missing some invalidating
steps.
----
> IncidentToAdjacentStrategy is buggy
> -----------------------------------
>
> Key: TINKERPOP-1545
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1545
> Project: TinkerPop
> Issue Type: Bug
> Components: process
> Affects Versions: 3.1.4, 3.2.3
> Reporter: Daniel Kuppitz
> Assignee: Daniel Kuppitz
>
> {{IncidentToAdjacentStrategy}} turns {{outE().inV().simplePath()}} into
> {{out().simplePath()}}, which will return a wrong result as soon as there is
> more than 1 edge between a pair of vertices.
> The set {{INVALIDATING_STEP_CLASSES}} should only contain
> {{PathProcessor.class}} and {{LambdaHolder.class}} Furthermore
> {{SimplePathStep}} should implement {{PathProcessor}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
