[
https://issues.apache.org/jira/browse/TINKERPOP-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15814808#comment-15814808
]
ASF GitHub Bot commented on TINKERPOP-1549:
-------------------------------------------
Github user okram commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/529#discussion_r95350852
--- Diff:
gremlin-groovy-test/src/main/groovy/org/apache/tinkerpop/gremlin/process/traversal/step/filter/GroovyRangeTest.groovy
---
@@ -108,5 +108,15 @@ public abstract class GroovyRangeTest {
public Traversal<Vertex, Map<String, String>>
get_g_V_asXaX_out_asXbX_out_asXcX_selectXa_b_cX_byXnameX_rangeXlocal_1_2X() {
new ScriptTraversal<>(g, "gremlin-groovy",
"g.V.as('a').out.as('b').out.as('c').select('a','b','c').by('name').range(local,1,2)")
}
+
+ @Override
+ public Traversal<Vertex, Long> get_g_V_skipX2X_count() {
+ new ScriptTraversal<>(g, "gremlin-groovy",
"g.V.skip(2).count()")
--- End diff --
I would replace this test with one that is an
`order().by(...).skip(2)`-style test so you know its actually skipping the
"first 2" and not just giving you two results back. Likewise for your
`skip(local)`-test.
> Implement skip()
> ----------------
>
> Key: TINKERPOP-1549
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1549
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Reporter: Daniel Kuppitz
> Assignee: Daniel Kuppitz
>
> We should have a {{.skip(x)}} and {{.skip(local, x)}}. The functionality is
> already provided by {{RangeStep}} ({{.range(x, -1)}} skips {{x}} elements and
> emits the remainder).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
