GitHub user okram opened a pull request:

    https://github.com/apache/tinkerpop/pull/530

    TINKERPOP-1531: 
DedupTest.g_V_asXaX_repeatXbothX_timesX3X_emit_asXbX_group_byXselectXaXX_byXselectXbX_dedup_order_byXidX_foldX_selectXvaluesX_unfold_dedup
 assumes id implements Comparable

    https://issues.apache.org/jira/browse/TINKERPOP-1531
    
    We were ordering on `T.id` and not all providers have `Comparable` ids. The 
test has been updated (and renamed) to use vertex names.
    
    VOTE +1.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1531

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/530.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #530
    
----
commit 683c2dfa80ddb2fe5f9c19e6a3f9d6f9e9db4950
Author: Marko A. Rodriguez <okramma...@gmail.com>
Date:   2017-01-10T18:19:37Z

    DedupTest now uses name for the order() instead of id.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to