[ 
https://issues.apache.org/jira/browse/TINKERPOP-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15829781#comment-15829781
 ] 

ASF GitHub Bot commented on TINKERPOP-1248:
-------------------------------------------

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/538
  
    I see that you added new Gryo registrations. I assume that GraphSON can 
serialize `ProjectedTraverser` as there is a general serializer for that. What 
about `MultiComparator` - is that a concern? To extend on this issue given my 
recent work in the testing of IO, I'm wondering why certain registrations in 
Gryo don't require equal "registrations" in GraphSON. Are our tests coming up 
short in ensuring they have parity? Are we unnecessarily registering in Gryo 
sometimes? 
    
    I noticed there's no additional tests. I assume that this is because 
existing tests cover this functionality and no new breaks equals no problems.


> OrderGlobalStep should use local star graph to compute sorts, prior to 
> reduction.
> ---------------------------------------------------------------------------------
>
>                 Key: TINKERPOP-1248
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1248
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.2.0-incubating
>            Reporter: Marko A. Rodriguez
>            Assignee: Marko A. Rodriguez
>
> We can get local star graph expressivity from `OrderGlobalStep` in OLAP if we 
> emit the object + its `by()`-modulated values. It will yield more data in the 
> order, but it will reduce the CPU time as we don't have to call `by()` on 
> each order check.
> This ticket will be a bit involved as it will depart from 
> `CollectingBarrierStep` semantics and thus, complicate `OrderGlobalSteps` 
> implementation... 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to