[ 
https://issues.apache.org/jira/browse/TINKERPOP-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15866509#comment-15866509
 ] 

ASF GitHub Bot commented on TINKERPOP-1633:
-------------------------------------------

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/557
  
    I've had some time to review this. I have a few additional tweaks if you 
don't mind. In the pom.xml you edited you can removed this `<repository>`:
    
    ```xml
    <repository>
      <id>jitpack.io</id>
      <url>https://jitpack.io</url>
    </repository>
    ```
    
    You can also remove this entry in the docs:
    
    
https://github.com/apache/tinkerpop/blame/2decc8132ff8726e35e722b8b35475dfa4b2b47c/docs/src/reference/gremlin-applications.asciidoc#L53
    
    There is an entry in `grapeConfig.xml` in the docker directories and a 
second entry on the gremlin-applications.asciidoc, but both look like those 
changes were added on the tp32 branch and not here on tp31 - I will take care 
of that stuff after merging your PR.
    



> use org.mindrot:jbcrypt v0.4
> ----------------------------
>
>                 Key: TINKERPOP-1633
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1633
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: build-release
>            Reporter: Zach A. Thomas
>
> I have followed Sonatype's guidelines for deploying third party artifacts, 
> and jbcrypt v0.4 is now in Maven Central.
> Unlike alternative jbcrypts available, this is Damien Miller's code 
> _unmodified_.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to