GitHub user okram opened a pull request:

    https://github.com/apache/tinkerpop/pull/562

    TINKERPOP-1626: choose() is buggy in OLAP

    https://issues.apache.org/jira/browse/TINKERPOP-1626
    
    `ComputerAwareStep.EndStep` was using `path.extend()` and not 
`traverser.addLabel()` to append step labels in OLAP and thus, the step label 
data wasn't being recorded because `path.extend()` is an immutable operation. 
Also, updated `PathRetractionStrategy` to look like `LazyBarrierStrategy's` 
recent tweaks to not add a barrier to the end of a traversal -- leave that up 
to `RemoteStrategy`.
    
    VOTE +1.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1626

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/562.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #562
    
----
commit 012edf17531f5b4ce979351bdfde504a32437800
Author: Marko A. Rodriguez <[email protected]>
Date:   2017-02-22T16:59:09Z

    fixed a bug in OLAP ComputerAwareStep.EndStep where labels were not being 
appended to the traverser correctly. Also, a small optimization tweak to 
PathRetractionStrategy to mirror the barrier-optimization retraction that was 
done earlier on tp32/ around LazyBarrierStrategy.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to