Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/567
  
    I like this way better than the synchronization. I have some reservations 
about:
    
    ```java
    CompletableFuture.supplyAsync(() -> loader.parseClass(script, 
generateScriptName()));
    ```
    
    That's going to use the `ForkJoinPool` to execute the compilation, which is 
a shared thread pool for the JVM that isn't configurable and basically outside 
of our control. Of course, getting rid of it means adding a new 
`ExecutorService` that we can configure and monitor in 
`GremlinGroovyScriptEngine`.  Making that kind of change goes pretty deep into 
various aspects of TinkerPop. If @BrynCooke is ok with the changes I can merge 
what he has to a branch since it seems like we have general consensus on the 
approach and then make some additional changes and re-issue the PR for a final 
VOTE.  If there's no objections I'll start work on that first thing tomorrow.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to