[
https://issues.apache.org/jira/browse/TINKERPOP-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15905329#comment-15905329
]
ASF GitHub Bot commented on TINKERPOP-1438:
-------------------------------------------
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/569
yeah - that's an obvious truth @pluradj . Normally we wouldn't allow such a
change on `tp32` because it does immediately make people's code not compile if
they used that class in that way but this class is fairly internal. If someone
is using it they likely know what they are doing. @dpitera I tend to agree that
this is outside the scope of what would need to remain compatible. That said, I
think you will have to add an entry to the upgrade docs (i guess the user
section???) about this breaking change and just mention how they go about
fixing it (i.e. use the `DefaultGraphManager`). We'll probably also want to
send a quick email to the dev list to just alert everyone to a break to make
sure no one is buggin' about that. Finally, the JIRA issue will need the
"breaking" label added to it.
> Consider GraphManager as an interface
> -------------------------------------
>
> Key: TINKERPOP-1438
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1438
> Project: TinkerPop
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.2.2
> Reporter: stephen mallette
> Priority: Minor
> Labels: breaking
>
> If {{GraphManager}} were an interface it would make embedding Gremlin Server
> easier as {{Graph}} instances could be more easily supplied by the host
> application. In doing this, It also might be good to force a
> {{TraversalSource}} to be referred to by both the {{Graph}} name and
> {{TraversalSource}} name.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
