Looks like the mirrors are synchronised. I just released Gremlin-Scala 3.2.5.0 as well :)
On 19/06/17 12:54, Stephen Mallette wrote:
The tp32 branch is re-opened for development. Packages have been released - just waiting for the mirrors now and then we can announce. On Thu, Jun 15, 2017 at 4:35 PM, Stephen Mallette <[email protected]> wrote:Since I got the new VOTE thread out today, I think we can likely count on announcing the two releases on Monday afternoon. On Thu, Jun 15, 2017 at 1:57 PM, Stephen Mallette <[email protected]> wrote:Yes - please close the vote on 3.1.7. We will just hold off publishing artifacts to central and announcing until the 3.2.5 release is done. Thanks! On Thu, Jun 15, 2017 at 1:52 PM, Ted Wilmes <[email protected]> wrote:Good deal, should I close out the vote for 3.1.7 tonight, barring any -1's and then we can hold off on the announcement to coincide with 3.2.5? --Ted On Thu, Jun 15, 2017 at 12:28 PM, Stephen Mallette <[email protected]wrote:Kuppitz (who has the day off today) just informed me that the fix hewasresponsible for is in. I'm going to restart the release process -Hopefullyi'll have a new VOTE thread opened up by end of day. On Thu, Jun 15, 2017 at 9:34 AM, Stephen Mallette <[email protected]>wrote:It seems that way. It could only be a problem if someone submittedgryobytecode generated from something other than our GraphTraversal implementation. That seems unlikely so I guess this was a lesserproblemthan I thought - oh well. On Thu, Jun 15, 2017 at 9:15 AM, Robert Dale <[email protected]>wrote:So I guess inside, outside, and between are never actuallyserializeddirectly because they become a composition of other predicates? Robert Dale On Thu, Jun 15, 2017 at 8:48 AM, Robert Dale <[email protected]>wrote:Was working on serializing JanusGraph predicates - geo, text - for withRemote. Since those predicates become P, I had to borrow andmodifytheTinkerPop P serializer and noticed that something's not like theother.Robert Dale On Thu, Jun 15, 2017 at 8:37 AM, Stephen Mallette <[email protected]wrote:Robert, how did you go about hitting that problem withP.inside()? Itoccurs to me now that this was so deadly a bug because I'm notsureweever end up actually serializing an "inside". On Thu, Jun 15, 2017 at 6:23 AM, Stephen Mallette <[email protected]>wrote:We do have a test for P.inside in the process tests but Ididn'trealizethat it doesn't compile to a P.inside at bytecode serializationtime:gremlin> g.V(1).outE().has("weight", P.inside(0.0d,0.6d)).inV().explain()==>Traversal Explanation ============================================================ ============================================================ =========================== Original Traversal [GraphStep(vertex,[1]), VertexStep(OUT,edge), HasStep([weight.and(gt(0.0), lt(0.6))]), EdgeVertexStep(IN)] ConnectiveStrategy [D] [GraphStep(vertex,[1]), VertexStep(OUT,edge), HasStep([weight.and(gt(0.0), lt(0.6))]), EdgeVertexStep(IN)] MatchPredicateStrategy [O] [GraphStep(vertex,[1]), VertexStep(OUT,edge), HasStep([weight.and(gt(0.0), lt(0.6))]), EdgeVertexStep(IN)] FilterRankingStrategy [O] [GraphStep(vertex,[1]), VertexStep(OUT,edge), HasStep([weight.and(gt(0.0), lt(0.6))]), EdgeVertexStep(IN)] InlineFilterStrategy [O] [GraphStep(vertex,[1]), VertexStep(OUT,edge), HasStep([weight.and(gt(0.0), lt(0.6))]), EdgeVertexStep(IN)] IncidentToAdjacentStrategy [O] [GraphStep(vertex,[1]), VertexStep(OUT,edge), HasStep([weight.and(gt(0.0), lt(0.6))]), EdgeVertexStep(IN)] AdjacentToIncidentStrategy [O] [GraphStep(vertex,[1]), VertexStep(OUT,edge), HasStep([weight.and(gt(0.0), lt(0.6))]), EdgeVertexStep(IN)] RepeatUnrollStrategy [O] [GraphStep(vertex,[1]), VertexStep(OUT,edge), HasStep([weight.and(gt(0.0), lt(0.6))]), EdgeVertexStep(IN)] RangeByIsCountStrategy [O] [GraphStep(vertex,[1]), VertexStep(OUT,edge), HasStep([weight.and(gt(0.0), lt(0.6))]), EdgeVertexStep(IN)] PathRetractionStrategy [O] [GraphStep(vertex,[1]), VertexStep(OUT,edge), HasStep([weight.and(gt(0.0), lt(0.6))]), EdgeVertexStep(IN)] LazyBarrierStrategy [O] [GraphStep(vertex,[1]), VertexStep(OUT,edge), HasStep([weight.and(gt(0.0), lt(0.6))]), EdgeVertexStep(IN)] TinkerGraphCountStrategy [P] [GraphStep(vertex,[1]), VertexStep(OUT,edge), HasStep([weight.and(gt(0.0), lt(0.6))]), EdgeVertexStep(IN)] TinkerGraphStepStrategy [P][TinkerGraphStep(vertex,[1]),VertexStep(OUT,edge), HasStep([weight.and(gt(0.0), lt(0.6))]), EdgeVertexStep(IN)] ProfileStrategy [F][TinkerGraphStep(vertex,[1]),VertexStep(OUT,edge), HasStep([weight.and(gt(0.0), lt(0.6))]), EdgeVertexStep(IN)] StandardVerificationStrategy [V][TinkerGraphStep(vertex,[1]),VertexStep(OUT,edge), HasStep([weight.and(gt(0.0), lt(0.6))]), EdgeVertexStep(IN)] Final Traversal[TinkerGraphStep(vertex,[1]),VertexStep(OUT,edge), HasStep([weight.and(gt(0.0), lt(0.6))]), EdgeVertexStep(IN)] We likely need more direct serialization tests of P, but Ithinkthosealready exist in master. Made a note to review further afterrelease.On Wed, Jun 14, 2017 at 3:57 PM, Robert Dale <[email protected]>wrote:Fix pushed to tp32 and master. Robert Dale On Wed, Jun 14, 2017 at 3:50 PM, Stephen Mallette <[email protected]>wrote:Well - now that the VOTE on 3.2.5 is cancelled we can nowfix upthesecouple of issues, specifically: 1. anyStepRecursively() bug (kuppitz is going to handlethat)2. Gryo serialization of inside() (robert dale, you had thefixforthat -do you want to just CTR that in? though i'm also interestedinwhytestsdidn't catch that problem) I'm going to leave out the other issue noted: https://issues.apache.org/jira/browse/TINKERPOP-1691 as it is not user facing - just something related to thetestsuite(providers at least have a workaround for that if they hitproblemsastheycan @OptOut). I also don't intend to deploy another SNAPSHOT so i'm justgoingtokeep uson "3.2.5" and not revert to "3.2.5-SNAPSHOT". Let's justpatchthisupthen I'll start on a fresh release packaging tomorrow. Any other concerns? On Tue, Jun 6, 2017 at 6:27 AM, Robert Dale <[email protected]>wrote:That will probably work too. I usehttps://wummel.github.io/linkchecker/Robert Dale On Tue, Jun 6, 2017 at 6:20 AM, Daniel Kuppitz<[email protected]wrote:https://validator.w3.org/checklink On Tue, Jun 6, 2017 at 12:18 PM, Stephen Mallette <[email protected]>wrote:huh - that's a neat idea. is there a specific tool youuse?On Tue, Jun 6, 2017 at 5:48 AM, Robert Dale <[email protected]wrote:Linkchecker passes. Robert Dale On Mon, Jun 5, 2017 at 6:38 AM, Stephen Mallette <[email protected]wrote:I published latest docs for 3.2.5-SNAPSHOT: http://tinkerpop.apache.org/docs/3.2.5-SNAPSHOT/ and made another deployment to the Apache SnapshotRepoafterthoseTinkerFactory adjustments. On Fri, Jun 2, 2017 at 8:39 PM, Stephen Mallette <[email protected]wrote:Just a reminder that code is frozen on the tp32branchstartingtomorrow(Saturday) and for the following week. We'll usethisthread todiscussanyissues or problems on 3.2.5 that are foundduringtesting.Therearenoopen pull requests and no outstanding issuesthatI'mawareof.I'vepublished a TinkerPop 3.2.5-SNAPSHOT forproviderstotestagainst(ortheymay build themselves - whatever is moreconvenient).Thanks, Stephen
