[ https://issues.apache.org/jira/browse/TINKERPOP-999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16056304#comment-16056304 ]
ASF GitHub Bot commented on TINKERPOP-999: ------------------------------------------ GitHub user spmallette opened a pull request: https://github.com/apache/tinkerpop/pull/638 TINKERPOP-999 Removed generics from ServerGremlinExecutor https://issues.apache.org/jira/browse/TINKERPOP-999 Pretty simple - I probably could have CTR'd this but since it was a breaking change on 3.3.0 I wanted folks to be more aware of it in case someone was using this class in some way I'm not imagining. Builds with `mvn clean install -DskipTests && mvn verify -pl gremlin-server -DskipIntegrationTests=false` VOTE +1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-999 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/638.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #638 ---- commit 4c89e1594537f02c4bb3f0efa60f3e5042621442 Author: Stephen Mallette <sp...@genoprime.com> Date: 2017-06-20T19:14:44Z TINKERPOP-999 Removed generics from ServerGremlinExecutor ---- > ServerGremlinExecutor construction need not use generics for ExecutorService > ---------------------------------------------------------------------------- > > Key: TINKERPOP-999 > URL: https://issues.apache.org/jira/browse/TINKERPOP-999 > Project: TinkerPop > Issue Type: Improvement > Components: server > Affects Versions: 3.1.0-incubating > Reporter: stephen mallette > Assignee: stephen mallette > Priority: Minor > Labels: breaking > Fix For: 3.3.0 > > > See TINKERPOP3-912 for more information but the {{ServerGremlinExecutor}} > will always need be bound to Netty so there's not much need for use of > generics in the class definition. Remove unecessary constructors and perhaps > scope them internal as this class will not be publicly constructed. This > will be a breaking change. -- This message was sent by Atlassian JIRA (v6.4.14#64029)