Github user dkuppitz commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/638#discussion_r123119092
  
    --- Diff: 
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/GremlinServer.java
 ---
    @@ -108,54 +108,24 @@ public GremlinServer(final Settings settings) {
                 workerGroup = new NioEventLoopGroup(settings.threadPoolWorker, 
threadFactoryWorker);
             }
     
    -        serverGremlinExecutor = new ServerGremlinExecutor<>(settings, 
null, workerGroup, EventLoopGroup.class);
    +        serverGremlinExecutor = new ServerGremlinExecutor(settings, null, 
workerGroup, null);
    --- End diff --
    
    Looks like the 4th parameter is no longer needed. Since the PR targets 
`master/`, it would be fine to remove it altogether, no?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to