[ 
https://issues.apache.org/jira/browse/TINKERPOP-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057362#comment-16057362
 ] 

Florian Hockmann commented on TINKERPOP-1552:
---------------------------------------------

{quote}
The solution would be to parse the json using Json.NET (as is) but use dynamic 
in our public API, which is a good fit for parsed json.
{quote}
I don't know if using {{dynamic}} for an argument in a public method is a good 
idea as a you then don't really know what you get. When we keep the 
deserializers as they are right know, then we would still be bound to Json.NET. 
We would only hide this fact which makes it more confusing in my opinion. A 
cleaner option would be to just use {{string}}, so that the deserializer can 
deserialize the element completely from GraphSON, but that would of course 
require some additional work that is currently not needed.
I personally think that the approach with {{JToken}} is the best compromise at 
the moment. But I'm of course open to changing that as it is definitely not an 
ideal solution. What do others think about this matter?

{quote}
Can we list the pending items for this GLV to be included on TinkerPop? that 
way we can all help to close this one.
{quote}
At least from my side Gremlin-DotNet is now ready to be published as a _beta_ 
version. For the first official release we probably need the testing framework 
[~spmallette] mentioned. There are some other improvements I have in mind, but 
they really aren't necessary for the first release. So we can track those with 
separate tickets later on.
By the way, I will be on vacation until end of next week. So I can't help with 
any issues until then.

> C# Gremlin Language Variant
> ---------------------------
>
>                 Key: TINKERPOP-1552
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1552
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: language-variant
>    Affects Versions: 3.2.3
>            Reporter: Jorge Bay
>            Assignee: stephen mallette
>
> It would be nice to have a C# GLV that runs under .NET Framework 4.5+ and 
> .NET Core.
> The maven build could use the Exec Maven Plugin to exec .NET Core's [dotnet 
> test|https://www.microsoft.com/net/core#macos] command.
> Some requirements, from the mailing list (edited):
> {quote}
> 1. The GLV should keep in line with class/method names of the java API
> where possible to ensure consistency of feel across languages.
> 2. There needs to be adequate tests (we're still discussing the approach to
> testing GLVs and i think that needs to be tackled sooner than later as more
> GLVs start to come in). Those tests should produce xunit style output
> unless there is some good reason not to.
> 3. There needs to be adequate documentation (e.g. Reference docs)
> 4. The build/deploy process needs to be bound to maven which might be one of 
> the trickier bits to deal with.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to