[
https://issues.apache.org/jira/browse/TINKERPOP-1669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059321#comment-16059321
]
ASF GitHub Bot commented on TINKERPOP-1669:
-------------------------------------------
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/639
TINKERPOP-1669: EdgeVertexStep should be designed for extension
https://issues.apache.org/jira/browse/TINKERPOP-1669
`EdgeVertexStep` is no longer final and can be extended by providers.
VOTE +1.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1669
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/639.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #639
----
----
> EdgeVertexStep should be designed for extension
> -----------------------------------------------
>
> Key: TINKERPOP-1669
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1669
> Project: TinkerPop
> Issue Type: Improvement
> Components: process, structure
> Affects Versions: 3.2.4
> Reporter: Bryn Cooke
>
> GraphStep, VertexStep and PropertiesStep are all not final, so I was
> surprised to find that I couldn't extend EdgeVertexStep. In the end I had to
> duplicate the entire class....
> If there are concerns about simply making this class non-final then it could
> be designed for extension by making most of the methods final (except
> toString), but the leaving the class non-final.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
