[ 
https://issues.apache.org/jira/browse/TINKERPOP-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066560#comment-16066560
 ] 

ASF GitHub Bot commented on TINKERPOP-1703:
-------------------------------------------

GitHub user okram opened a pull request:

    https://github.com/apache/tinkerpop/pull/641

    TINKERPOP-1703: Make DsegEdgeOtherVertexStep non-final

    https://issues.apache.org/jira/browse/TINKERPOP-1703
    
    The ticket really is about making {{EdgeOtherVertexStep}} non-final so 
providers, like DSEGraph, can extend it accordingly.
    
    Simple fix.
    
    **SIDENOTE**: @dkuppitz -- I wonder if there is a more efficient way to 
implement this step. I looked into using `Path.get(i)`, but it seems while it 
makes less data, it is more expensive to execute (at least for `ImmutablePath`).
    
    VOTE +1.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1703

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/641.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #641
    
----
commit 2543cb4f3d876a54585f4b4b92849c372d394f2f
Author: Marko A. Rodriguez <okramma...@gmail.com>
Date:   2017-06-28T14:15:54Z

    EdgeOtherVertexStep is no longer final and can be extended by providers.

----


> Make DsegEdgeOtherVertexStep non-final
> --------------------------------------
>
>                 Key: TINKERPOP-1703
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1703
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>            Reporter: Bryn Cooke
>
> I missed this in TINKERPOP-1669.
> To recap, having element steps non final is helpful to implementations as 
> they can leave the majority of the traversal steps alone, and only replace 
> the element steps.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to