[
https://issues.apache.org/jira/browse/TINKERPOP-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066608#comment-16066608
]
ASF GitHub Bot commented on TINKERPOP-1704:
-------------------------------------------
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/642
TINKERPOP-1704: XXXTranslators are not being respective of BulkSet and Tree.
https://issues.apache.org/jira/browse/TINKERPOP-1704
`JavaTranslator` would convert `Tree` to `HashMap` and `BulkSet` to
`HashSet`. While passing in such objects through `Bytecode` is low probability,
it is still good to cover this corner case (especially for `Tree`, where the
semantics are a bit different than `Map`).
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1704
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/642.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #642
----
commit 506b921c947a9ec8536bd0e739b2df3d2b5440ae
Author: Marko A. Rodriguez <okramma...@gmail.com>
Date: 2017-06-28T14:39:37Z
JavaTranslator is now smart about handling BulkSet and Tree in Bytecode.
This is a low probability usage, but a usage none-the-less...
----
> XXXTranslators are not being respective of BulkSet and Tree.
> ------------------------------------------------------------
>
> Key: TINKERPOP-1704
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1704
> Project: TinkerPop
> Issue Type: Bug
> Components: process
> Affects Versions: 3.2.5
> Reporter: Marko A. Rodriguez
> Assignee: Marko A. Rodriguez
>
> After working on TINKERPOP-1701, I note that the {{XXXTranslators}} are not
> smart about {{BulkSet}} and {{Tree}} and may inadvertently translate them to
> {{HashSet}} and {{HashMap}}, respectively. Dar.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
