[ 
https://issues.apache.org/jira/browse/TINKERPOP-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16103414#comment-16103414
 ] 

ASF GitHub Bot commented on TINKERPOP-1736:
-------------------------------------------

GitHub user dkuppitz opened a pull request:

    https://github.com/apache/tinkerpop/pull/684

    TINKERPOP-1736 Sack step evaluated by groovy interprets numbers in an 
unexpected way

    Follow-up on #682. This PR fixes the test case that failed in `master/`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1736-master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/684.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #684
    
----
commit 3d8c03bb2c3cdd09a44e8b163d62db6d18773490
Author: Daniel Kuppitz <daniel_kupp...@hotmail.com>
Date:   2017-07-27T16:07:25Z

    Fixed test case that ultimately failed in `master/` (coerced `BigDecimal` 
to `Double`).

commit 76709da19ee61ff1a25acd49760fa69adc9d0ab5
Author: Daniel Kuppitz <daniel_kupp...@hotmail.com>
Date:   2017-07-27T16:10:15Z

    Merge branch 'TINKERPOP-1736' into TINKERPOP-1736-tp32

commit e363a5e1c800ef7c3b730d9811c8c4d2aae596c9
Author: Daniel Kuppitz <daniel_kupp...@hotmail.com>
Date:   2017-07-27T16:11:57Z

    Merge branch 'TINKERPOP-1736-tp32' into TINKERPOP-1736-master

----


> Sack step evaluated by groovy interprets numbers in an unexpected way
> ---------------------------------------------------------------------
>
>                 Key: TINKERPOP-1736
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1736
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: process
>    Affects Versions: 3.2.5
>            Reporter: stephen mallette
>            Assignee: Daniel Kuppitz
>             Fix For: 3.3.0, 3.1.8, 3.2.6
>
>
> The issue is discussed to some detail on the dev mailing list:
> https://lists.apache.org/thread.html/6b8060c89f5b3744e7a9d1e421b9de980a3e24eb50563423c7690893@%3Cdev.tinkerpop.apache.org%3E
> but basically, this fails:
> {code}
> gremlin> g.withSack(2).V().sack(div).by(constant(3.0)).sack()
> Non-terminating decimal expansion; no exact representable decimal result.
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to