GitHub user dkuppitz opened a pull request:

    https://github.com/apache/tinkerpop/pull/697

    TINKERPOP-1753 OrderStep not able to order by non-integer numbers

    https://issues.apache.org/jira/browse/TINKERPOP-1753
    
    Fixed ordering of collections / streams containing mixed number types.
    
    I decided to go with `try / catch`, since this should really be an 
exceptional case. Usually number types shouldn't be mixed up, hence I didn't 
want this PR to have a negative impact on the overall order performance by 
always checking the types upfront.
    
    VOTE: +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1753

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/697.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #697
    
----
commit 75187be79f97deef26c76f176cc0c8ea50dac1cb
Author: Daniel Kuppitz <daniel_kupp...@hotmail.com>
Date:   2017-08-17T13:37:45Z

    Fixed ordering of collections / streams containing mixed number types.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to