[
https://issues.apache.org/jira/browse/TINKERPOP-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16132984#comment-16132984
]
ASF GitHub Bot commented on TINKERPOP-1753:
-------------------------------------------
GitHub user dkuppitz opened a pull request:
https://github.com/apache/tinkerpop/pull/697
TINKERPOP-1753 OrderStep not able to order by non-integer numbers
https://issues.apache.org/jira/browse/TINKERPOP-1753
Fixed ordering of collections / streams containing mixed number types.
I decided to go with `try / catch`, since this should really be an
exceptional case. Usually number types shouldn't be mixed up, hence I didn't
want this PR to have a negative impact on the overall order performance by
always checking the types upfront.
VOTE: +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1753
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/697.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #697
----
commit 75187be79f97deef26c76f176cc0c8ea50dac1cb
Author: Daniel Kuppitz <daniel_kupp...@hotmail.com>
Date: 2017-08-17T13:37:45Z
Fixed ordering of collections / streams containing mixed number types.
----
> OrderStep not able to order by non-integer numbers
> --------------------------------------------------
>
> Key: TINKERPOP-1753
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1753
> Project: TinkerPop
> Issue Type: Bug
> Components: process
> Affects Versions: 3.2.5
> Reporter: Daniel Kuppitz
> Assignee: Daniel Kuppitz
>
> {{order()}} and {{order(local)}} sometimes fail to sort by non-integer
> numbers. In some cases it works, but the following pattern (non-integer map
> values?) seems broken:
> {noformat}
> gremlin>
> g.V().hasLabel("person").group().by("name").by(outE().values("weight").sum()).order(local).by(values)
> java.lang.Double cannot be cast to java.lang.Integer
> Type ':help' or ':h' for help.
> Display stack trace? [yN]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
