[ 
https://issues.apache.org/jira/browse/TINKERPOP-1759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144388#comment-16144388
 ] 

ASF GitHub Bot commented on TINKERPOP-1759:
-------------------------------------------

Github user okram commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/699#discussion_r135642343
  
    --- Diff: 
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/traverser/LP_O_OB_P_S_SE_SL_Traverser.java
 ---
    @@ -106,17 +106,18 @@ public void dropPath() {
     
         @Override
         public int hashCode() {
    -        return super.hashCode() + this.path.hashCode();
    +        if (carriesUnmergeableSack()) {
    --- End diff --
    
    Can you use inline `returns carriesUnmergableSack() ? ... : ...` please?


> Improve hashcode and equals for Traverser implementations
> ---------------------------------------------------------
>
>                 Key: TINKERPOP-1759
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1759
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.2.6
>            Reporter: Daniel Kuppitz
>            Assignee: Daniel Kuppitz
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to