[
https://issues.apache.org/jira/browse/TINKERPOP-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16155170#comment-16155170
]
ASF GitHub Bot commented on TINKERPOP-1766:
-------------------------------------------
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/704
Thanks for your comments so far, I'll implement the changes you suggested.
I definitely agree that the driver and especially the connection pool needs
to be improved and I would really appreciate any effort you (and of course als
anyone else) put into this as I'm not exactly an expert in writing database
drivers.
Could you clarify what you mean with _request pipelining on the same
connection_? If you mean sending multiple requests in parallel over the same
websocket connection, then I think that it's not possible as [the
documentation](https://docs.microsoft.com/en-us/dotnet/api/system.net.websockets.clientwebsocket.sendasync?view=netframework-4.7#Remarks)
states that
> Exactly one send and one receive is supported on each ClientWebSocket
object in parallel.
The upside of this is of course that the implementation of the `Connection`
and the `ConnectionPool` is much simpler when every `Connection` can just send
one single request at a time as we don't have to match incoming responses with
the correct requests they belong to.
> Gremlin.Net: Closed connections should not be re-used
> ------------------------------------------------------
>
> Key: TINKERPOP-1766
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1766
> Project: TinkerPop
> Issue Type: Bug
> Components: language-variant
> Affects Versions: 3.3.0, 3.2.6
> Reporter: Florian Hockmann
>
> The driver of Gremlin.Net is kept very simle which holds especially true for
> the {{ConnectionPool}}. It simply returns every connection to its pool of
> usable connections that was {{disposed}} by the client. Unfortunately, this
> also applies in case the submit failed due to an already closed connection
> which means that the client will get the closed connection back from the
> {{ConnectionPool}} later and continues trying to submit messages over this
> closed connection.
> This can be fixed by checking whether the {{Connection}} is still open before
> adding it back to the {{ConnectionPool}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
