[ 
https://issues.apache.org/jira/browse/TINKERPOP-1767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16155868#comment-16155868
 ] 

ASF GitHub Bot commented on TINKERPOP-1767:
-------------------------------------------

GitHub user spmallette opened a pull request:

    https://github.com/apache/tinkerpop/pull/706

    TINKERPOP-1767 Added Io.requiresVersion(Object)

    https://issues.apache.org/jira/browse/TINKERPOP-1767
    
    Allows the graph provider to determine type and version of the Io being 
constructed so that they can properly choose the right IoRegistry to assign. 
Also set the defaults for GraphSON and Gryo to 3.0 when doing `graph.io()` 
(should have been done for 3.3.0 unfortunately).
    
    running full test suite now - will update this PR when complete with my vote

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1767

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/706.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #706
    
----
commit 0d266da3e5c274afa9306367263e5c9098bedd93
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2017-09-06T16:02:53Z

    TINKERPOP-1767 Added Io.requiresVersion(Object)
    
    Allows the graph provider to determine type and version of the Io being 
constructed so that they can properly choose the right IoRegistry to assign.

----


> Method for graph providers to check an IO version and type
> ----------------------------------------------------------
>
>                 Key: TINKERPOP-1767
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1767
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: io
>    Affects Versions: 3.3.0
>            Reporter: stephen mallette
>            Assignee: stephen mallette
>             Fix For: 3.3.1
>
>
> The basic problem is described here:
> https://lists.apache.org/thread.html/5d46643614c5306d38bfbec11cee3aaffff7653f440d276e7cbe189e@%3Cdev.tinkerpop.apache.org%3E
> but in summary, the graph provider needs a way to check the type of io and 
> version so that they have the opportunity to assign the correct instance of 
> their {{IoRegistry}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to