[
https://issues.apache.org/jira/browse/TINKERPOP-1730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16161503#comment-16161503
]
ASF GitHub Bot commented on TINKERPOP-1730:
-------------------------------------------
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/710#discussion_r138113216
--- Diff:
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Process/Traversal/DriverRemoteConnection/SideEffectTests.cs
---
@@ -129,10 +139,8 @@ public void
ShouldReturnBothSideEffectForTraversalWithTwoSideEffects_()
Assert.Equal(2, keys.Count);
Assert.Contains("m", keys);
Assert.Contains("n", keys);
- var n = (Dictionary<object, long>) t.SideEffects.Get("n");
- Assert.Equal(2, n.Count);
- Assert.Equal(3, n["lop"]);
- Assert.Equal(1, n["ripple"]);
+ var n = (IList<object>) t.SideEffects.Get("n");
+ Assert.Equal(n.Select(tr => ((Traverser)tr).Object), new[]
{"lop", "ripple"});
--- End diff --
Please switch the sides of the arguments here as the expected value should
be the first argument and the actual value the second. Otherwise the messages
for a failed test can become misleading.
> Gremlin .NET support for GraphSON 3.0
> -------------------------------------
>
> Key: TINKERPOP-1730
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1730
> Project: TinkerPop
> Issue Type: Improvement
> Components: language-variant
> Affects Versions: 3.3.0
> Reporter: stephen mallette
> Priority: Minor
>
> This may be a quite minor thing at this point as [~jorgebg] already had much
> of this in place. GraphSON 3.0 should be the default for 3.3.0 - right now it
> is set to 2.0 so all the tests pass.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
