Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/710#discussion_r138113216
--- Diff:
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Process/Traversal/DriverRemoteConnection/SideEffectTests.cs
---
@@ -129,10 +139,8 @@ public void
ShouldReturnBothSideEffectForTraversalWithTwoSideEffects_()
Assert.Equal(2, keys.Count);
Assert.Contains("m", keys);
Assert.Contains("n", keys);
- var n = (Dictionary<object, long>) t.SideEffects.Get("n");
- Assert.Equal(2, n.Count);
- Assert.Equal(3, n["lop"]);
- Assert.Equal(1, n["ripple"]);
+ var n = (IList<object>) t.SideEffects.Get("n");
+ Assert.Equal(n.Select(tr => ((Traverser)tr).Object), new[]
{"lop", "ripple"});
--- End diff --
Please switch the sides of the arguments here as the expected value should
be the first argument and the actual value the second. Otherwise the messages
for a failed test can become misleading.
---
