[ 
https://issues.apache.org/jira/browse/TINKERPOP-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165348#comment-16165348
 ] 

ASF GitHub Bot commented on TINKERPOP-1782:
-------------------------------------------

Github user okram commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/714#discussion_r138748892
  
    --- Diff: 
gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/RangeByIsCountStrategyTest.java
 ---
    @@ -99,6 +99,9 @@
                     {__.and(__.out().count().is(0), __.in().count().is(1)), 
__.and(__.not(__.out()), __.in().limit(2).count().is(1))},
                     {__.and(__.out().count().is(1), __.in().count().is(0)), 
__.and(__.out().limit(2).count().is(1), __.not(__.in()))},
                     {__.or(__.out().count().is(0), __.in().count().is(0)), 
__.or(__.not(__.out()), __.not(__.in()))},
    +                {__.path().filter(__.count().is(gte(0.5))).limit(5), 
__.path().identity().limit(5)}, // unfortunately we can't just remove the 
filter step
    --- End diff --
    
    Why can't you remove the `filter()` step? That is, why the `identity()` 
step replacement?


> RangeByIsCountStrategy doesn't handle floating point numbers properly
> ---------------------------------------------------------------------
>
>                 Key: TINKERPOP-1782
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1782
>             Project: TinkerPop
>          Issue Type: Bug
>    Affects Versions: 3.2.6
>            Reporter: Daniel Kuppitz
>            Assignee: Daniel Kuppitz
>
> See: https://groups.google.com/d/msg/gremlin-users/90IY6QMp4YQ/w60l_pfvCgAJ



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to