Github user FlorianHockmann commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/716#discussion_r139986227
  
    --- Diff: gremlin-dotnet/glv/Gremlin.Net.csproj.template ---
    @@ -25,7 +25,9 @@ limitations under the License.
       </PropertyGroup>
     
       <PropertyGroup Label="Package">
    -    <Version>${projectVersion}</Version>
    +    <Version>$projectVersion</Version>
    +    <FileVersion>$projectVersion.0</FileVersion>
    --- End diff --
    
    My suggestion was to replace this:
    ```xml
    <Version>3.2.7-SNAPSHOT</Version>
    <FileVersion>3.2.7.0</FileVersion>
    <AssemblyVersion>3.2.0.0</AssemblyVersion>
    ```
    by this:
    ```xml
    <VersionPrefix>3.2.7</VersionPrefix>
    <VersionSuffix>SNAPSHOT</VersionSuffix>
    <FileVersion>3.2.7.0</FileVersion>
    <AssemblyVersion>3.2.0.0</AssemblyVersion>
    ```
    as the second option seems to be easier to generate, but both are 
completely valid and we can stay with the first option when you already managed 
to adapt the generation for that.


---

Reply via email to