[
https://issues.apache.org/jira/browse/TINKERPOP-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179214#comment-16179214
]
ASF GitHub Bot commented on TINKERPOP-1752:
-------------------------------------------
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/712#discussion_r140812056
--- Diff: gremlin-dotnet/glv/GraphTraversal.template ---
@@ -65,9 +65,17 @@ namespace Gremlin.Net.Process.Traversal
/// <summary>
/// Adds the <%= method.methodName %> step to this <see
cref="GraphTraversal{SType, EType}" />.
/// </summary>
- public GraphTraversal< <%= method.t1 %> , <%= method.t2 %> > <%=
toCSharpMethodName.call(method.methodName) %><%= method.tParam %> (params
object[] args)
+ public GraphTraversal< <%= method.t1 %> , <%= method.t2 %> > <%=
toCSharpMethodName.call(method.methodName) %><%= method.tParam %> (<%=
method.parameters %>)
{
- Bytecode.AddStep("<%= method.methodName %>", args);
+ <% if (method.parameters.contains("params ")) {
+ %> var args = new List<object> {<%=
method.paramNames.init().join(", ") %>};
--- End diff --
We should set the initial capacity of the list to avoid unnecessary
resizing of the underlying array.
It should be the sum of the length of `method.paramNames.init()` and
`method.paramNames.last()`.
> Gremlin.Net: Generate completely type-safe methods
> --------------------------------------------------
>
> Key: TINKERPOP-1752
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1752
> Project: TinkerPop
> Issue Type: Improvement
> Components: dotnet
> Affects Versions: 3.2.5
> Reporter: Florian Hockmann
> Priority: Minor
>
> Currently the generated traversal methods in Gremlin.Net take {{params
> object[] args}} as an argument which allows the user to provide an arbitrary
> number of arguments with any type. While this makes the generation rather
> simple, it doesn't tell the user which arguments are actually valid so users
> can submit completely invalid traversals like:
> {code}
> g.V(1).AddE(1234, "invalidArgument2").Next()
> {code}
> Type-safe methods could also use the original argument names to tell users
> something about what kind of values the methods expect. Consider for example
> the following method signatures for the C# step {{AddE}} that are basically a
> 1:1 representation of the original Java {{addE}} step:
> {code}
> public GraphTraversal< S , Edge > AddE (Direction direction, string
> firstVertexKeyOrEdgeLabel, string edgeLabelOrSecondVertexKey, params object[]
> propertyKeyValues);
> public GraphTraversal< S , Edge > AddE (string edgeLabel);
> {code}
> Implementing this should make TINKERPOP-1725 obsolete and also resolve
> TINKERPOP-1751.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
