[
https://issues.apache.org/jira/browse/TINKERPOP-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16186115#comment-16186115
]
ASF GitHub Bot commented on TINKERPOP-1661:
-------------------------------------------
GitHub user dkuppitz opened a pull request:
https://github.com/apache/tinkerpop/pull/725
TINKERPOP-1661 Docker-built documentation does not always point locally
https://issues.apache.org/jira/browse/TINKERPOP-1661
That was much easier than I thought. I started by pushing directories
around and updating links in most of the asciidoc files. Then I realized, that
this can be a simple 2 line change in Docker's build script (it's basically
just a global `sed` replacement and a symlink).
VOTE: +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1661
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/725.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #725
----
commit 82fb125891276ed610e1e7f195758120de20ae84
Author: Daniel Kuppitz <daniel_kupp...@hotmail.com>
Date: 2017-09-29T17:14:46Z
Update links to all docs pages in Docker build and emulate the published
directory structure. This way the docs are easier to navigate in local builds.
----
> Docker-built documentation does not always point locally
> --------------------------------------------------------
>
> Key: TINKERPOP-1661
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1661
> Project: TinkerPop
> Issue Type: Improvement
> Components: build-release
> Affects Versions: 3.2.4
> Reporter: Robert Dale
> Assignee: Daniel Kuppitz
> Priority: Minor
>
> After performing {{docker/build.sh -d}}
> When I pull up the initial URL to look at the docs, it's local -
> http://172.17.0.2/ .
> Anchor links to the same page are also local - http://172.17.0.2/#tutorials .
> However, all links to other pages are remote! Also, you can't just replace
> the server name with the local IP, the URL is slightly different. e.g.
> http://tinkerpop.apache.org/docs/3.3.0-SNAPSHOT/reference
> must be changed to http://172.17.0.2/reference/ in order to view it locally.
> If the reviewer isn't paying attention to the url, s/he might be reviewing
> the wrong content. It would be better if it were all local and/or relative
> paths.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
