Yes. We should have only a primitive ProfileTest that ensures that a TraversalMetrics object is returned and that is it.
Marko. > On Oct 26, 2017, at 12:35 PM, Stephen Mallette <spmalle...@gmail.com> wrote: > > I racked my brain on it a bit a while back without any good fix....it's > really a TinkerGraph test. I probably should just migrate them over there > and stop pressing them down on other providers. > > On Thu, Oct 26, 2017 at 2:31 PM, pieter gmail <pieter.mar...@gmail.com> > wrote: > >> In Sqlg many profile tests are ignored because of this. Including steps >> being removed. >> Back in the day no-one including myself had any interest in fixing it. Its >> not trivial by all accounts. >> >> Cheers >> Pieter >> >> On 26/10/2017 13:21, Bryn Cooke (JIRA) wrote: >> >>> Bryn Cooke created TINKERPOP-1812: >>> ------------------------------------- >>> >>> Summary: ProfileTest assumes that graph implementations >>> will not add their own steps >>> Key: TINKERPOP-1812 >>> URL: https://issues.apache.org/jira >>> /browse/TINKERPOP-1812 >>> Project: TinkerPop >>> Issue Type: Test >>> Components: process >>> Affects Versions: 3.2.6 >>> Reporter: Bryn Cooke >>> >>> >>> The following two tests check the number of steps in the traversal: >>> g_V_sideEffectXThread_sleepX10XX_sideEffectXThread_sleepX5XX >>> _profileXmetricsX >>> g_V_sideEffectXThread_sleepX10XX_sideEffectXThread_sleepX5XX_profile >>> >>> This assumes that graph implementations add no steps to the traversal. >>> They should probably be checking the structure of the traversal rather than >>> the total number of steps. For instance that each step is followed by a >>> profile step and that the profile side effect step and cap step are the >>> last steps. >>> >>> >>> >>> -- >>> This message was sent by Atlassian JIRA >>> (v6.4.14#64029) >>> >> >>
