Github user spmallette commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/745#discussion_r150381081
  
    --- Diff: 
tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerIndex.java
 ---
    @@ -48,17 +48,18 @@ public TinkerIndex(final TinkerGraph graph, final 
Class<T> indexClass) {
     
         protected void put(final String key, final Object value, final T 
element) {
             Map<Object, Set<T>> keyMap = this.index.get(key);
    -        if (keyMap == null) {
    -            keyMap = new ConcurrentHashMap<>();
    -            this.index.put(key, keyMap);
    +        if (null == keyMap) {
    +            Map<Object, Set<T>> tmpMap = new ConcurrentHashMap<>();
    --- End diff --
    
    can you add a `final` here please?


---

Reply via email to