[ https://issues.apache.org/jira/browse/TINKERPOP-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16249011#comment-16249011 ]
ASF GitHub Bot commented on TINKERPOP-1784: ------------------------------------------- GitHub user spmallette opened a pull request: https://github.com/apache/tinkerpop/pull/747 TINKERPOP-1784 GLV Test Framework https://issues.apache.org/jira/browse/TINKERPOP-1784 This PR is for the GLV Test Framework. It contains an implementation for gremlin-python. It is not a complete porting of all the process test suite, but does provide coverage for almost all steps. I think I've built enough here to provide enough for evaluation of the framework itself - my intention is to backfill tests after this merges. I do think I have enough tests here to yield confidence in GLVs that implement it, thus allowing baseline for official release. All tests pass with `docker/build.sh -t -n -i` VOTE +1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-1784 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/747.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #747 ---- commit 61e667ddb91eb96560793843054678d4c0a925de Author: Stephen Mallette <sp...@genoprime.com> Date: 2017-09-14T19:44:32Z TINKERPOP-1784 Initial implementation of a new language agnostic test suite Uses Gherkin to write test specifications that will be implemented by the various GLVs. Provided a basic implementation for gremlin-python. commit ce16228ea8780b0ff60f0ff1a11a4a127dde6744 Author: Stephen Mallette <sp...@genoprime.com> Date: 2017-09-20T17:32:54Z TINKERPOP-1784 Use python eval() to setup test traversals commit 2b92f5b20ba5e8c9f7e49f1e5ac7428c284d6603 Author: Stephen Mallette <sp...@genoprime.com> Date: 2017-09-20T17:39:00Z TINKERPOP-1784 Categorize feature by step type This matches he pattern of the java test suite. commit eb595a6c737fa0d49df3c0062c7c463088fecda6 Author: Stephen Mallette <sp...@genoprime.com> Date: 2017-09-20T22:38:49Z TINKERPOP-1784 Added coin() gherkin tests and refactored python commit 7aa1adcb3d1a719cb75b218bb9fa3a83112213de Author: Stephen Mallette <sp...@genoprime.com> Date: 2017-09-22T14:52:20Z TINKERPOP-1784 Expanded GLV test framework a bit further Developed methods for vertices/maps and a way to assert unordered results. commit b129ed30b02388710e9c39338026462d4cf88955 Author: Stephen Mallette <sp...@genoprime.com> Date: 2017-09-22T16:56:08Z TINKERPOP-1784 Added some basic support to convert vertex string to a vertex object This might be the pattern to use across the board. We'll see if there is a better idea floating about though so may not be final. commit de32b78efe432e6b57399ca9db673ddeead313ad Author: Stephen Mallette <sp...@genoprime.com> Date: 2017-09-22T17:49:50Z TINKERPOP-1784 Minor refactoring of python gherkin steps commit 35aca028cbc0ccd96823e842626169b7d7b7f1e7 Author: Stephen Mallette <sp...@genoprime.com> Date: 2017-09-22T18:43:13Z TINKERPOP-1784 Added support for numeric keys in glv tests commit 14b8d3bbeacf0ee1ec500174009c8487aa1238a6 Author: Stephen Mallette <sp...@genoprime.com> Date: 2017-09-23T11:12:07Z TINKERPOP-1784 Added test for select in GLV tests Included infrastructure for validating maps and refactored other related code. commit 17fd3b027effc0f7b055e1934307b2c4b90ed84b Author: Stephen Mallette <sp...@genoprime.com> Date: 2017-09-27T16:16:08Z TINKERPOP-1784 Provided translation for python specific syntax Included a way to specify element identifiers in feature files. commit 655377380654755fb031b9d92e10fd9376665b68 Author: Stephen Mallette <sp...@genoprime.com> Date: 2017-09-27T17:26:17Z TINKERPOP-1784 Added test to enforce implementation of process tests as features commit db6c8560d883891d0c3c53ab0fc7a9b40adca9d3 Author: Stephen Mallette <sp...@genoprime.com> Date: 2017-09-27T20:18:14Z TINKERPOP-1784 Added edge assertion support commit f33b2b8d588d68e0374958b5aa37b32c9dc59211 Author: Stephen Mallette <sp...@genoprime.com> Date: 2017-09-28T14:29:47Z TINKERPOP-1784 Added some more vertex tests commit 55145980b99ed78a1de82ecefe199062439ea573 Author: Stephen Mallette <sp...@genoprime.com> Date: 2017-09-28T18:54:40Z TINKERPOP-1784 Changed assertion logic and table formats in feature files commit bed1d7c5e7aa0d1cd7fbed9914c541c48c79df86 Author: Stephen Mallette <sp...@genoprime.com> Date: 2017-09-28T19:17:14Z TINKERPOP-1784 Refactored the assertion logic for ordered/unordered commit a9f273f603c08d958a4a25cdc7504a9a1a91bd30 Author: Stephen Mallette <sp...@genoprime.com> Date: 2017-09-28T19:30:54Z TINKERPOP-1784 Deleted some dead code commit 80a5a0121e36c6380619de59361ebffdd40e9287 Author: Stephen Mallette <sp...@genoprime.com> Date: 2017-09-29T14:29:38Z TINKERPOP-1784 Add support for the various toy graphs commit 9975980bca2fe1f50f05d53b4fd2f6ab6b6bb4a7 Author: Stephen Mallette <sp...@genoprime.com> Date: 2017-09-29T15:54:33Z TINKERPOP-1784 Included grateful graph and cached remotes/data Tests should be faster now that remotes and data are cached for the toy graphs. commit e46e3a2f1828f78ba6bdd84e1e3e6c440a42d043 Author: Stephen Mallette <sp...@genoprime.com> Date: 2017-09-29T17:26:27Z TINKERPOP-1784 Added some more vertex features commit ea41b581cdb127e09fee7819c02b0bbf43532bf9 Author: Stephen Mallette <sp...@genoprime.com> Date: 2017-09-29T19:44:50Z TINKERPOP-1784 Completed the VertexTest cases commit c54e3bdffaab511b544286ceda06a3c1088d62be Author: Stephen Mallette <sp...@genoprime.com> Date: 2017-10-01T11:28:31Z TINKERPOP-1784 Added do nothings for unsupported tests commit 2a5298ae80a2416ccdb83e8091f7959f8a9ed616 Author: Stephen Mallette <sp...@genoprime.com> Date: 2017-10-02T18:59:59Z TINKERPOP-1784 Get all count() tests working Needed to add support for cleaning up traversal strings to more properly handle reserved python words. commit 933b89f28addc2de200e02cf5cdb164b60605c7a Author: Stephen Mallette <sp...@genoprime.com> Date: 2017-10-03T17:06:19Z TINKERPOP-1784 Added another feature test for groupCount() commit e718176486f4406d3cfcf90aae0e7528ee156523 Author: Stephen Mallette <sp...@genoprime.com> Date: 2017-10-03T19:48:49Z TINKERPOP-1784 Add all tests for groupCount() commit 8fddf699995c56b9e075188b6c83403a37a02b12 Author: Stephen Mallette <sp...@genoprime.com> Date: 2017-10-05T13:23:09Z TINKERPOP-1784 Added more select() tests commit 47e6c531653cfb29e3b52ffb12792a48be1ebf08 Author: Stephen Mallette <sp...@genoprime.com> Date: 2017-10-05T15:49:19Z TINKERPOP-1784 Added more select() tests commit 918a56ec6877d75fe348d8e7a5ce4dc66706ca7a Author: Stephen Mallette <sp...@genoprime.com> Date: 2017-10-10T17:17:55Z TINKERPOP-1784 Added support for testing branch() with gherkin commit 39b8417185292e6f7fb0e3c099439a6d7da94ae8 Author: Stephen Mallette <sp...@genoprime.com> Date: 2017-10-10T19:18:55Z TINKERPOP-1784 Define traversals without shorthand Sorta made the decision to be explicit in how traversals are defined in .feature files. Shying away from using shorthand static imports which will make it more explicit for those trying to implement the tests. commit 4a6772c6755a791992747bd4ff9e1c2b9ac80fac Author: Stephen Mallette <sp...@genoprime.com> Date: 2017-10-10T19:39:40Z TINKERPOP-1784 Added multi-line support in the .feature files commit 6d2d835542a022baca0e6042a48e06811e73dfc2 Author: Stephen Mallette <sp...@genoprime.com> Date: 2017-10-11T14:52:15Z TINKERPOP-1784 Added Choose tests to .feature files ---- > Gremlin Language Test Suite > --------------------------- > > Key: TINKERPOP-1784 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1784 > Project: TinkerPop > Issue Type: Improvement > Components: test-suite > Affects Versions: 3.2.6 > Reporter: stephen mallette > Assignee: stephen mallette > > Provide for a more language agnostic test framework for the Gremlin Language > so that we can properly test GLVs. The current test suite is completely tied > to the JVM. -- This message was sent by Atlassian JIRA (v6.4.14#64029)