Github user jorgebay commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/747#discussion_r150477310
  
    --- Diff: gremlin-python/pom.xml ---
    @@ -440,6 +440,17 @@ limitations under the License.
                                                 <env key="PYTHONPATH" 
value=""/>
                                                 <arg line="setup.py test"/>
                                             </exec>
    +                                        <!-- radish seems to like all 
dependencies in place -->
    +                                        <exec executable="env/bin/python" 
dir="${project.build.directory}/python2"
    +                                              failonerror="true">
    +                                            <env key="PYTHONPATH" 
value=""/>
    +                                            <arg line="setup.py install"/>
    +                                        </exec>
    +                                        <exec executable="env/bin/radish" 
dir="${project.build.directory}/python2"
    +                                              failonerror="true">
    +                                            <env key="PYTHONPATH" 
value=""/>
    +                                            <arg line="-e -t -b 
${project.build.directory}/python2/radish 
${project.basedir}/../gremlin-test/features/"/> <!-- -no-line-jump -->
    +                                        </exec>                            
                                      
    --- End diff --
    
    Nit: undesired additional spaces after `exec` close tag.


---

Reply via email to