Github user FlorianHockmann commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/741#discussion_r150529077
  
    --- Diff: 
gremlin-python/src/main/jython/tests/structure/io/test_graphson.py ---
    @@ -121,6 +125,19 @@ class X(object):
             serdes.objectify.assert_called_once_with(value, reader)
             assert o is serdes.objectify()
     
    +    def test_datetime(self):
    +        dt = self.graphson_reader.readObject(json.dumps({"@type": 
"g:Date", "@value": 1481750076295}))
    +        assert isinstance(dt, datetime.datetime)
    --- End diff --
    
    Wouldn't it make sense to also assert that the value is correct here? Then 
the test would validate the GraphSON reader completely and it stays consistent 
with the other tests in this class.


---

Reply via email to