[ 
https://issues.apache.org/jira/browse/TINKERPOP-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16249521#comment-16249521
 ] 

ASF GitHub Bot commented on TINKERPOP-1807:
-------------------------------------------

Github user FlorianHockmann commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/741#discussion_r150529077
  
    --- Diff: 
gremlin-python/src/main/jython/tests/structure/io/test_graphson.py ---
    @@ -121,6 +125,19 @@ class X(object):
             serdes.objectify.assert_called_once_with(value, reader)
             assert o is serdes.objectify()
     
    +    def test_datetime(self):
    +        dt = self.graphson_reader.readObject(json.dumps({"@type": 
"g:Date", "@value": 1481750076295}))
    +        assert isinstance(dt, datetime.datetime)
    --- End diff --
    
    Wouldn't it make sense to also assert that the value is correct here? Then 
the test would validate the GraphSON reader completely and it stays consistent 
with the other tests in this class.


> Gremlin-Python doesn't support GraphSON types g:Date, g:Timestamp and g:UUID
> ----------------------------------------------------------------------------
>
>                 Key: TINKERPOP-1807
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1807
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: python
>    Affects Versions: 3.3.0, 3.2.6
>            Reporter: Florian Hockmann
>
> Apparently the GraphSON types {{g:Date}}, {{g:Timestamp}} and {{g:UUID}} are 
> currently not supported in Gremlin-Python.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to