[ 
https://issues.apache.org/jira/browse/TINKERPOP-1830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16250633#comment-16250633
 ] 

ASF GitHub Bot commented on TINKERPOP-1830:
-------------------------------------------

Github user mpollmeier commented on the issue:

    https://github.com/apache/tinkerpop/pull/745
  
    ok that's done. added a changelog entry, merged this branch into tp32 and 
merged tp32 into master. 


> Race condition in Tinkergraph index creation 
> ---------------------------------------------
>
>                 Key: TINKERPOP-1830
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1830
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: tinkergraph
>    Affects Versions: 3.3.0, 3.2.6
>            Reporter: Michael Pollmeier
>            Priority: Minor
>             Fix For: 3.2.7, 3.3.1
>
>
> My colleage Fabian Yamaguchi <f...@shiftleft.io> discovered a race condition 
> in tinkergraph's index creation. He fixed it by simply replacing 
> `parallelStream` with `stream`. Quoting his analysis:
> > So, reading the code, you see that this.put is called in parallel, but that 
> > method seems to contain a race as get is called on the index, checked for 
> > null, and a subsequent write is performed. It still seems like using stream 
> > here fixes the problem we've been seeing, and the performance hit is not 
> > significant.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to