Github user FlorianHockmann commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/754#discussion_r154526959 --- Diff: gremlin-dotnet/src/Gremlin.Net/Structure/IO/GraphSON/DecimalConverter.cs --- @@ -0,0 +1,34 @@ +#region License + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#endregion + +using System; + +namespace Gremlin.Net.Structure.IO.GraphSON +{ + internal class DecimalConverter : NumberConverter --- End diff -- Could you please add two unit tests that read and write a `decimal`? We have those tests for all other writers and readers, including the numerical ones, so we should stay consistent and also add them here.
---