Github user spmallette commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/778#discussion_r161835490
  
    --- Diff: 
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/gryo/GryoVersion.java
 ---
    @@ -305,6 +307,7 @@ public String getVersion() {
                 add(GryoTypeReg.of(RangeGlobalStep.RangeBiOperator.class, 
114));
                 add(GryoTypeReg.of(OrderGlobalStep.OrderBiOperator.class, 118, 
new JavaSerializer()));
                 add(GryoTypeReg.of(ProfileStep.ProfileBiOperator.class, 119));
    +            add(GryoTypeReg.of(VertexTraverserSet.class, 173));
    --- End diff --
    
    please move the "last id" comment down from:
    
    
https://github.com/apache/tinkerpop/pull/778/files#diff-f1eb3822f6d5659dd2bdc913ae475241R208
    
    you might need to create a separate PR against master for us to review 
because of this change because Gryo 3.0 will need a similar entry on master (i 
suspect the kryo id will be different) and we'd need to be sure this all works 
on master as well.


---

Reply via email to