[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327733#comment-16327733 ]
ASF GitHub Bot commented on TINKERPOP-1862: ------------------------------------------- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/777 When I run the integration tests with `docker/build.sh -t -i` I get some failures in spark - do they fail for you too @PBGraff ? ```text [ERROR] Tests run: 619, Failures: 0, Errors: 3, Skipped: 149, Time elapsed: 237.084 s <<< FAILURE! - in org.apache.tinkerpop.gremlin.spark.process.computer.SparkGraphComputerProcessIntegrateTest [ERROR] testMessagePassingOut(org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest) Time elapsed: 0.001 s <<< ERROR! java.lang.UnsupportedOperationException: Graph does not support adding vertices at org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest.runTest(GraphComputerTest.java:2666) at org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest.testMessagePassingOut(GraphComputerTest.java:2637) [ERROR] testMessagePassingBoth(org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest) Time elapsed: 0 s <<< ERROR! java.lang.UnsupportedOperationException: Graph does not support adding vertices at org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest.runTest(GraphComputerTest.java:2666) at org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest.testMessagePassingBoth(GraphComputerTest.java:2652) [ERROR] testMessagePassingIn(org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest) Time elapsed: 0.001 s <<< ERROR! java.lang.UnsupportedOperationException: Graph does not support adding vertices at org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest.runTest(GraphComputerTest.java:2666) at org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest.testMessagePassingIn(GraphComputerTest.java:2622) [INFO] [INFO] Results: [INFO] [ERROR] Errors: [ERROR] org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest.testMessagePassingBoth(org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest) [ERROR] Run 1: GraphComputerTest.testMessagePassingBoth:2652->runTest:2666 ? UnsupportedOperation [ERROR] Run 2: GraphComputerTest.testMessagePassingBoth:2652->runTest:2666 ? UnsupportedOperation [INFO] [ERROR] org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest.testMessagePassingIn(org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest) [ERROR] Run 1: GraphComputerTest.testMessagePassingIn:2622->runTest:2666 ? UnsupportedOperation [ERROR] Run 2: GraphComputerTest.testMessagePassingIn:2622->runTest:2666 ? UnsupportedOperation [INFO] [ERROR] org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest.testMessagePassingOut(org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest) [ERROR] Run 1: GraphComputerTest.testMessagePassingOut:2637->runTest:2666 ? UnsupportedOperation [ERROR] Run 2: GraphComputerTest.testMessagePassingOut:2637->runTest:2666 ? UnsupportedOperation [INFO] [INFO] [ERROR] Tests run: 1625, Failures: 0, Errors: 3, Skipped: 267 ``` > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > ----------------------------------------------------------------------------------------- > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph > Affects Versions: 3.2.7 > Reporter: Philip Graff > Priority: Major > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v7.6.3#76005)