[
https://issues.apache.org/jira/browse/TINKERPOP-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331860#comment-16331860
]
ASF GitHub Bot commented on TINKERPOP-1868:
-------------------------------------------
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/776#discussion_r162555342
--- Diff: gremlin-dotnet/glv/GraphTraversal.template ---
@@ -68,7 +68,7 @@ namespace Gremlin.Net.Process.Traversal
public GraphTraversal< <%= method.t1 %> , <%= method.t2 %> > <%=
toCSharpMethodName.call(method.methodName) %><%= method.tParam %> (<%=
method.parameters %>)
{
<% if (method.parameters.contains("params ")) {
- %> var args = new List<object>(<%=
method.paramNames.init().size() %> + <%= method.paramNames.last() %>.Length)
{<%= method.paramNames.init().join(", ") %>};
+ %> var args = new List< <%= method.argsListType %> >(<%=
method.paramNames.init().size() %> + <%= method.paramNames.last() %>.Length)
{<%= method.paramNames.init().join(", ") %>};
--- End diff --
Wow, nice!
I've reviewed the end result and looks good.
> Support inject source step in Gremlin.Net
> -----------------------------------------
>
> Key: TINKERPOP-1868
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1868
> Project: TinkerPop
> Issue Type: Improvement
> Components: dotnet
> Affects Versions: 3.2.7, 3.3.1
> Reporter: Florian Hockmann
> Priority: Minor
>
> {{GraphTraversalSource}} has no {{Inject}} step in Gremlin.Net because it's
> explicitly excluded in the GLV generation:
> {code}
> "sourceSpawnMethods": GraphTraversalSource.getMethods(). // SPAWN STEPS
> findAll { GraphTraversal.class.equals(it.returnType)
> && !it.name.equals('inject')}.
> // ...
> {code}
> I don't know why {{inject}} is explicitly excluded here, but there should be
> an implementation in {{GraphTraversalSource}} as the other GLVs also have
> this step.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
