[
https://issues.apache.org/jira/browse/TINKERPOP-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332804#comment-16332804
]
ASF GitHub Bot commented on TINKERPOP-1874:
-------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/785
TINKERPOP-1874 master
See #784 on tp32 for specific details. This change has a lot of extra stuff
because I included IO test resources for 3.3.2 to `gremlin-io-test` so that I
could also include the new `P` objects in that part of the test suite.
Unfortunately, that made this PR look more complex than it is. There's really
no additional changes of substance for solving the actual problem beyond what
was in #784
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1874-master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/785.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #785
----
commit 261b93b646c503068328d291224b430e4618410b
Author: Stephen Mallette <spmva@...>
Date: 2018-01-18T22:07:21Z
TINKERPOP-1874 Added tests around P
Validates various forms of serialization with focus on GraphSON and GLVs
(where there were problems).
commit 822b33174c87a2a918b3fc9df421585a57ef3345
Author: Stephen Mallette <spmva@...>
Date: 2018-01-19T13:18:25Z
TINKERPOP-1874 keep P.within and P.without using collection
GraphSON deserialization of P.within and P.without expects a single
collection regardless of the number of values, so even a single argument should
serialize to a list.
commit 1c33340277612ba81ee751d8f91297621d9476de
Author: Stephen Mallette <spmva@...>
Date: 2018-01-19T13:37:29Z
TINKERPOP-1874 Added P.within/out graphson examples for io docs
commit 7eaaa25d28955695a71d48814f818649927c0264
Author: Stephen Mallette <spmva@...>
Date: 2018-01-19T14:18:16Z
Merge branch 'TINKERPOP-1874' into TINKERPOP-1874-master
Conflicts:
docs/src/dev/io/graphson.asciidoc
gremlin-groovy-test/src/main/groovy/org/apache/tinkerpop/gremlin/process/traversal/step/filter/GroovyHasTest.groovy
commit 334314fb580a3ddb3603c44431aaf060f85bc729
Author: Stephen Mallette <spmva@...>
Date: 2018-01-19T14:53:47Z
TINKERPOP-1874 Added IO compatibility tests on P.within/out
Also added data for all the IO Tests for 3.3.2
commit e8cb62820bb7b1ed6dfc1473ee7c99c2febf0552
Author: Stephen Mallette <spmva@...>
Date: 2018-01-19T15:38:11Z
TINKERPOP-1874 Added some dev docs on IO testing/docs
----
> P does not appear to be serialized consistently in GraphSON
> -----------------------------------------------------------
>
> Key: TINKERPOP-1874
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1874
> Project: TinkerPop
> Issue Type: Bug
> Components: io
> Affects Versions: 3.2.7
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Major
>
> {{P}} deserialization seems to expect {{List}} arguments for collection
> oriented operators like {{within}} and {{outside}} so {{P.without("x")}}
> should wrap "x" in a {{List}} for serialization purposes. This causes
> weirdness in some GLVs. For example in .NET we see that the use of
> {{P.without("x")}} fails to deserialize the bytecode, but {{P.Without(new
> List<string>{"x"})}} will work fine. Just need to get this all straight and
> consistent.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
