[
https://issues.apache.org/jira/browse/TINKERPOP-1857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355258#comment-16355258
]
Jorge Bay commented on TINKERPOP-1857:
--------------------------------------
I've been looking at the failures and its a huge changeset to try to tackle all
of them at once.
Could you submit a pull request (marked as WIP), in order to start narrowing
down the issues on the GLV / test suite.
Here are some examples of underlying causes of failures on the JS :
(x)
{{g_V_hasLabelXpersonX_hasXage_notXlteX10X_andXnotXbetweenX11_20XXXX_andXltX29X_orXeqX35XXXX_name}}
The JavaScript sends a traversal in the form of:
{code}
{ step:
[ [ 'V' ],
[ 'hasLabel', 'person' ],
[ 'has',
'age',
{ '@type': 'g:P',
'@value':
{ predicate: 'not',
value: { '@type': 'g:P', '@value': { predicate: 'lte', value: 10 }
} } } ],
[ 'values', 'name' ] ] }
{code}
GraphSONMessageSerializerGremlinV2d0 seems to be unable to parse that bytecode,
but I don't see anything wrong with it.
(x) {{g_VXv2X_hasXage_gt_30X}}
Contains the following traversal: {{g.V(g.V(v4Id).next()).has("age",
P.gt(d30))}}.
We should avoid nested executions (it can't be resolved asynchronously). The
correct traversal would be {{g.V(v4).has("age", P.gt(d30))}}
There are around 120 new test scenarios, causing around 20 failures on the C#
GLV and several more on the JavaScript GLV. I think we should consider cutting
this into smaller pieces and assign them to different milestones / releases,
otherwise I doubt we have the manpower to fix the tests for those GLVs in a
timely manner.
> GLV test suite consistency and completeness
> -------------------------------------------
>
> Key: TINKERPOP-1857
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1857
> Project: TinkerPop
> Issue Type: Improvement
> Components: test-suite
> Affects Versions: 3.2.7
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Major
> Fix For: 3.2.8, 3.3.2
>
>
> While the GLV test suite was largely completed in 3.2.7/3.3.1 there were a
> number of tests that weren't fully migrated and minor naming inconsistencies
> that needed to be addressed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
