[ https://issues.apache.org/jira/browse/TINKERPOP-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16361996#comment-16361996 ]
ASF GitHub Bot commented on TINKERPOP-1854: ------------------------------------------- Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/792#discussion_r167789173 --- Diff: gremlin-dotnet/glv/generate.groovy --- @@ -48,7 +48,7 @@ def toCSharpTypeMap = ["Long": "long", "TraversalMetrics": "E2", "Traversal": "ITraversal", "Traversal[]": "ITraversal[]", - "Predicate": "TraversalPredicate", + "Predicate": "object", --- End diff -- I think we should use an interface `ILambda` similar to java's counterpart: https://github.com/apache/tinkerpop/blob/3.2.7/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/util/function/Lambda.java#L33 `Lambda.Groovy()` and `Lambda.Python()` could return `ILambda` instances. That way we can have a compile type check for methods like `Filter()`, `Until()`, etc... to accept only `ILambda` instances. > Support lambdas in Gremlin.Net > ------------------------------ > > Key: TINKERPOP-1854 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1854 > Project: TinkerPop > Issue Type: Improvement > Components: dotnet > Affects Versions: 3.3.0, 3.2.6 > Reporter: Florian Hockmann > Assignee: Florian Hockmann > Priority: Major > > Gremlin.Net should support lambdas. We already discussed this in [the pull > request for TINKERPOP-1752|https://github.com/apache/tinkerpop/pull/712]. > Here is what [~spmallette] said over there: > {quote} > Any reason we don't support lambdas? Even if .NET can't support them natively > for some reason wouldn't we minimally support the ability to pass a > python/groovy/etc lambda? it's kinda weird that way, but i think back to the > point that kuppitz made on the dev list the other day where he stated that he > doesn't always find a way out of using lambdas in production systems he works > on - so ultimately users will need that kind of capability i think. > {quote} > C# lambdas would require some kind of C# parser on the server side, so at > least in the beginning a way to send lambdas from already supported languages > in Gremlin.Net should be enough. -- This message was sent by Atlassian JIRA (v7.6.3#76005)