[GitHub] tinkerpop pull request #800: TINKERPOP-1726 Added idleReadLimit and idleWrit...

[spmallette]

Github user spmallette commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/800#discussion_r169343138
  
    --- Diff: 
gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerIntegrateTest.java
 ---
    @@ -293,6 +312,21 @@ private static SslContext createServerSslContext() {
             return scriptEngineConf;
         }
     
    +    @Test
    +    public void shouldPingChannelIfClientDies() throws Exception {
    --- End diff --
    
    good idea to just disable keepalive - that made it easier to write a test 
there. 


---